Add imageRegistry/imageNamespace to Helm chart image settings#782
Merged
SgtCoDFish merged 7 commits intomasterfrom Mar 5, 2026
Merged
Add imageRegistry/imageNamespace to Helm chart image settings#782SgtCoDFish merged 7 commits intomasterfrom
SgtCoDFish merged 7 commits intomasterfrom
Conversation
FelixPhipps
force-pushed
the
update-helm-secure
branch
from
cd947e1 to
f5064b2
Compare
SgtCoDFish
reviewed
Mar 3, 2026
FelixPhipps
force-pushed
the
update-helm-secure
branch
from
f5064b2 to
0678c6c
Compare
SgtCoDFish
requested changes
Mar 4, 2026
SgtCoDFish
reviewed
Mar 4, 2026
added 5 commits
March 5, 2026 11:32
Signed-off-by: felix.phipps <felix.phipps@cyberark.com>
Signed-off-by: felix.phipps <felix.phipps@cyberark.com>
Signed-off-by: felix.phipps <felix.phipps@cyberark.com>
Signed-off-by: felix.phipps <felix.phipps@cyberark.com>
Signed-off-by: felix.phipps <felix.phipps@cyberark.com>
FelixPhipps
force-pushed
the
update-helm-secure
branch
from
2ef81b2 to
617fdd7
Compare
added 2 commits
March 5, 2026 11:35
Signed-off-by: felix.phipps <felix.phipps@cyberark.com>
SgtCoDFish
approved these changes
Mar 5, 2026
Contributor
SgtCoDFish
left a comment
SgtCoDFish
left a comment
There was a problem hiding this comment.
/lgtm
/approve
The tests are now failing because of the disco backend bug and not because of anything in this PR. I'm confident we can merge this and move forwards with an alpha release.
Thanks for this @FelixPhipps !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds imageRegistry and imageNamespace values, aligning image configuration with cert-manager charts.
Implements https://github.com/cert-manager/cert-manager/blob/master/design/20260120.images-in-the-helm-chart.md (cert-manager/cert-manager#8425)